Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug where implicit prefetch and explicit prefetch behaviors were … #286

Merged
merged 3 commits into from
Aug 12, 2019

Conversation

ryochiji
Copy link
Contributor

@ryochiji ryochiji commented Jul 29, 2019

…inconsistent. Specifically, in the implicit prefetch scenario, the related serializer's filter_queryset() method wasn't being respected (because without that related field being included, part of the codepath didn't recognize it as a valid field).

@ryochiji ryochiji added the WIP label Jul 29, 2019
@ryochiji ryochiji force-pushed the fix/implicit-prefetch-bug branch from df01d6a to ad83e22 Compare August 2, 2019 01:17
@ryochiji ryochiji requested a review from aleontiev August 2, 2019 01:20
@ryochiji ryochiji removed the WIP label Aug 5, 2019
@ryochiji ryochiji requested a review from DeviateFish August 12, 2019 17:43
Copy link
Contributor

@DeviateFish DeviateFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style question, otherwise this looks good to me.

tests/serializers.py Outdated Show resolved Hide resolved
@ryochiji ryochiji merged commit 26ee4b5 into master Aug 12, 2019
@ryochiji ryochiji deleted the fix/implicit-prefetch-bug branch August 12, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants